This repository has been archived by the owner on Nov 26, 2021. It is now read-only.
remove custom class names + subnav overrides #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlee
approved these changes
Oct 8, 2018
gvonkoss
added a commit
that referenced
this pull request
Feb 4, 2019
* update logo url (#45) * remove custom class names + subnav overrides (#49) * rm custom class name * rm brand * Clean up (#50) * rm deprecated file * update use of brand * bump versions * linting * put the override back in ): * consolidate variables * pull out themes * change demo titles * brand variable * update to use flexbox (#52) * remove o-header & clean up (#53) * remove drawer * implement scroll on primary * remove o-header subnav styling * scroll both navs * start to convert primary nav to drop down * style drawer and add basic functionality * moar functionality nav collapses when any part of the page is clicked on * yesssssss impletments both drawer and scroll! * add jsDocs * handle some responsive behaviour * update header top styling * update primary nav styling * update sub nav styling * update themes and separate demos * update base styles * linting * remove traces of o-header * add SASSDocs * add tests and add resize listener * add tests * clean up * linting * add related content to primary nav when <740px * update README, clean up along the way * fixtures * last thing before holiday * fix tests * whoops commented out code * cascade bleed container * update scroll responsiveness * update scrolling to current selection * update README * oops * update dependencies removes dependencies on viewport/utils adds normalisation * change focus area * afhaldkjhafhl animations * make animations work * replace drawer with DropDown class * linting * pull scroll into class Scroll * clean up * clear out variables, correct sass * remove leaky sass * fix tests * get grid layout * ftlogo --> logo * linting * debounce scroll/resize * A11y (#55) * rm tabbing toggle * add a11y focus * remove container divs * focusout/esc and click all enabled when dropdown is open * linting as usual * change classname * concat some functions * Mono mixin (#56) * create monarch mixin * update sassdocs * sub nav -> secondary nav * use partial for pa11y * update classnames * update bleed styles * remove superfluous fixtures * signpost README * breadcrumb -> ancestors * slim down demos * update some readme * add handleEvent (#60) * add handleEvent * excellent Jake suggestion * 🤦 * ¯\_(ツ)_/¯ * update styling and markup to remove h1 from title (#59) * update styling and markup to remove h1 from title * revert class * update even handler * apply single $opts to primary mixin (#62) * Reimplement drawer (#63) * clean up demos * drawer appears from the left :magic: * handle long text/wrapping * update design * update more design and naming * update js * more sign posting for readme * clean up demos moar * Add whitelabel (#64) * add whitelabel * Update README.md Co-Authored-By: gvonkoss <gabivk@gmail.com> * remove unset value * update conditional without extra brand variable * update sassdocs * Update README, MIGRATION.md, JSDoc (#65) * add MIGRATION.md * update README * update jsdoc * rogue comment * we dont have this title anymore * reverse the diff * update themes!!! * Apply suggestions from code review Co-Authored-By: gvonkoss <gabivk@gmail.com> * Update README.md Co-Authored-By: gvonkoss <gabivk@gmail.com> * pin to new typography * No js transitions (#66) * remove setTimeout, add multi-step transitions * oops comments * update opacity * remove pointless display none that wasnt even working * fix tests * gaahhakdjhflakdsa linting * Hierarchical nav (#67) * start implementing drop down primary nav * adds drop down functionality * restructure, works on drawer, adds code docs * enable clicking in drawer * fix to work with internal * update demos * add support for core * add tests for dropdown * enable click outside of nav to collapse dropdowns * add test * linting * remove focusout * add text to demo for testing purposes * yaaaaas togle drawer yaaas * inverse hidden/open drawer * smol flash * add drop down repositioning * use spacing mixins * correct core experience * Nav w button (#68) * add button? * implement buttons * buttons in drawer * update for core * update tests * update demos to be more realistic * close menu button * rogue console.log * update tests * lint * add button classname and brand * enable custom branding * fix drawer * remove customisation * ugh typo * Documentation & customisation update (#69) * update migration * separate dropdown demo * update readme * update logo customisation * smol change * update grid * ***remove*** h1 * add whitelabel to origami.json * update brand customisation * fix top section * fix top section * update sassdoc * update sassdoc * correct awkward hover on whitelabel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #34