Conversation
There's no mega hack but there is a mini hack 馃槄 I'll add code comments on Monday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed something in one of the last PRs, but I have question 馃憞 and some smol comments 鉁岋笍
I like the non modifier non wrapper business though!
// Relative to the center aligned grid. | ||
position: relative; | ||
width: 100vw; | ||
left: #{calc((100vw - 100%) * -0.5)}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is happening because the grid doesn't span the whole page, right? Why did we remove the five columns again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's to remove the mega hack which calculated in SCSS a px value for the main content area. We either need a wrapper around the main content and sidebar, or we set the whole of .o-layout
to the max width of the container and then make the header and footer "break out" of the container (which is what this is).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, and the mega hack is bad because if the main content area is set in px it can't expand when the sidebar is deleted.
Co-Authored-By: notlee <notlee@users.noreply.github.com>
Makes the aside-sidebar of the query layout optional.
I think this is better for users than the wrapper approach and the previous modifier approach because it requires no additional markup. And we get to remove the
_getMainMaxWidth
mega hack 馃帀Unrelated this PR also corrects footer markup, and updates the migration guide accordingly.
Good
_getMainMaxWidth
super grossness).px
.Bad