Skip to content
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.

Breaking #27

Merged
merged 12 commits into from Nov 21, 2019
Merged

Breaking #27

merged 12 commits into from Nov 21, 2019

Conversation

notlee
Copy link
Contributor

@notlee notlee commented Sep 2, 2019

#25

notlee and others added 10 commits September 2, 2019 12:03
Restructure README. Remove cjs example.
- Adds `o-toggle-visibility`, to set `visibility: hidden`
on an active target.
- Adds `o-toggle-display`, to set `display: none` on an
active target.
- Keeps current behaviour without these classes.

#18
Add styles so o-toggle may be used without custom CSS.
Remove the ability to pass a callback function as a string.
@rowanmanning rowanmanning marked this pull request as ready for review November 21, 2019 14:11
@rowanmanning rowanmanning requested a review from a team as a code owner November 21, 2019 14:11
@origamiserviceuser
Copy link

o-toggle bundle size difference from 1.2.1 to 444bc55
js: 0.29kb increase (0.12kb/gzip)

@rowanmanning rowanmanning merged commit 5110f1a into master Nov 21, 2019
@rowanmanning rowanmanning deleted the breaking-2 branch November 21, 2019 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants