This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
adding focus style to default link styles #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is fine, but I'm going to move your comment to an issue to make it easier to track so it doesn't get lost. |
onishiweb
approved these changes
Feb 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alicebartlett @onishiweb
In other news, the nUiLinksTopic/oTypographyLinkTopic similarity is less strong than I'd hoped for. I'd still like to deprecate nUiLinksTopic, but I think you'd need to decide if it's safe to overwrite your mixin with an origamiized version of next's. In summary, next's goes darker on hover, whereas origami's goes lighter, and next's is opinionated about the border bottom style, whereas origami's just inherits from global link styles. Would also need to support progressive fonts