Redirect deprecated routes #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,13 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
what about putting this in the /deprecated folder?
There was a problem hiding this comment.
Good idea, I've moved it
|
|
||
| const request = require('supertest'); | ||
|
|
||
| describe('GET /v1/files', function() { |
There was a problem hiding this comment.
I'd personally find it easier if this was in the files.js but in a different describe, but I don't have a strong opinion about it
There was a problem hiding this comment.
Ah I'm trying to match the filenames in here to the URLs
There was a problem hiding this comment.
Yup, and that's fine as well, just wanted to mention my personal preference :P
|
Looks good! I don't think this should break in any way, files and modules haven't changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redirects file, module, and documentation routes in the same way as bundle routes are redirected.