This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
mark the image-set-tools as dead since image-sets now live within the image-service itself #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… image-service itself The image-set-tools was needed to create the imageset.json manifest and to upload the images to the correct S3 buckets. Now that the image-set lives within the origami-image-service (Financial-Times/origami-image-service#763) - we no longer need this tool at all
|
We can ignore the failing tests because we are archiving this project 👍 |
JakeChampion
added
the
release:patch
notlee
reviewed
Nov 16, 2021
notlee
approved these changes
Nov 16, 2021
Co-authored-by: Lee Moody <notlee@users.noreply.github.com>
|
🎉 This PR is included in version v2.3.16 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image-set-tools was needed to create the imageset.json manifest and to upload the images to the correct S3 buckets.
Now that the image-set lives within the origami-image-service (Financial-Times/origami-image-service#763) - we no longer need this tool at all