Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: duplicate versions/tags of components exist in the data #123

Open
JakeChampion opened this issue Aug 23, 2019 · 1 comment
Open

Bug: duplicate versions/tags of components exist in the data #123

JakeChampion opened this issue Aug 23, 2019 · 1 comment
Labels
bug Something isn't working service Relates to an Origami service
Projects

Comments

@JakeChampion
Copy link
Contributor

I think component versions are being duplicated because of a bug in the ingestion model saving --

const version = await app.model.Version.fetchOneByUrlAndTag(this.attributes.url, this.attributes.tag);

I also think that component authors sometimes delete a tag and then recreate the same tag, which causes origmai-repo-data to reingest. Perhaps origami-repo-data should listen to delete tag events and remove the tag/version from it's data?

Also, component authors tag sometimes with a v and then again without v (v13.0.0,13.0.0), which seems to cause duplications to appear in the data.

@chee chee added this to incoming in Origami ✨ Feb 1, 2020
@JakeChampion JakeChampion added bug Something isn't working service Relates to an Origami service labels Mar 24, 2020
notlee added a commit that referenced this issue Apr 20, 2021
This will delete 621 duplicates across 217 versions, plus
releases made today.

Some duplicates are caused by a fixed ingestion error:
#321

Others due to multiple tags of the same version (not fixed,
with automated tagging this is less likely to happen, and we
may decommission repo data):
#123

Rollback plan: restore from manual backup. I created a manual
backup this morning which we can restore from (see heroku >
resources).
notlee added a commit that referenced this issue Apr 20, 2021
This will delete 621 duplicates across 217 versions, plus
releases made today.

Some duplicates are caused by a fixed ingestion error:
#321

Others due to multiple tags of the same version (not fixed,
with automated tagging this is less likely to happen, and we
may decommission repo data):
#123

Rollback plan: restore from manual backup. I created a manual
backup this morning which we can restore from (see heroku >
resources).
@notlee
Copy link
Contributor

notlee commented Apr 20, 2021

We're deleting duplicate records but should keep this issue open as the problems outlined here still exist.

We haven't prioritised a fix as this particular issue is less likely to happen now components have an automatic tag and release workflow, based on Github labels, and we're chatting about possibly decommissioning repo data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working service Relates to an Origami service
Projects
Origami ✨
  
Backlog
Development

No branches or pull requests

2 participants