This repository has been archived by the owner on Nov 26, 2021. It is now read-only.
Make integration tests recursive #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably constitutes a breaking change. Currently services using this Makefile will not run all of the integration tests because the recursive flag is missing. I should have noticed this during testing. It's safe to always add the flag for our services as they all have a non-flat directory structure for the tests.
JakeChampion
approved these changes
Jul 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably constitutes a breaking change. Currently services using
this Makefile will not run all of the integration tests because the
recursive flag is missing. I should have noticed this during testing.
It's safe to always add the flag for our services as they all have a
non-flat directory structure for the tests.