This repository has been archived by the owner on Nov 26, 2021. It is now read-only.
Add a whitesource command #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanmanning
force-pushed
the
whitesource
branch
from
42af3a7
to
702f908
Compare
index.mk
Outdated
| @if [ -z "$(WHITESOURCE_API_KEY)" ]; then \ | ||
| echo "Warning: WHITESOURCE_API_KEY is not set, not running whitesource"; \ | ||
| else \ | ||
| npm install -g whitesource; \ |
There was a problem hiding this comment.
Can we install a specific version locally instead please
index.mk
Outdated
| echo "Warning: WHITESOURCE_API_KEY is not set, not running whitesource"; \ | ||
| else \ | ||
| npm install -g whitesource; \ | ||
| rm -rf node_modules && npm i --production; \ |
There was a problem hiding this comment.
This is no longer required as of version 1.8.0 of whitesource :-D
rowanmanning
force-pushed
the
whitesource
branch
from
702f908
to
7c322f0
Compare
| echo "Warning: WHITESOURCE_API_KEY is not set, not running whitesource"; \ | ||
| else \ | ||
| echo '{"apiKey": "$(WHITESOURCE_API_KEY)"}' > whitesource.config.json; \ | ||
| whitesource run; \ |
There was a problem hiding this comment.
If whitesource is not installed this would output an error along the lines of "command not found: whitesource".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.