Remove silent mode variable for spec v2 components #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlee
force-pushed
the
remove-silent-mode-variable
branch
from
f7af7b1
to
a89c7a2
Compare
JakeChampion
reviewed
Apr 9, 2021
Comment on lines
+57
to
+62
| @if not mixin-exists('oComponentName') { | ||
| @error 'Could not compile sass as o-component-name does not have a primary mixin. ' + | ||
| 'See the specification [... etc]'; | ||
| } | ||
|
|
||
| @include oComponentName(); |
There was a problem hiding this comment.
This is really nice, the build service v3 should use this implementation
notlee
commented
Apr 13, 2021
We would like to avoid expanding work required to complete the bower to npm migration
notlee
requested review from
chee and
JakeChampion
and removed request for
JakeChampion
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 4, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 4, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 4, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 4, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 4, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/o-test-component
that referenced
this pull request
May 5, 2021
…i spec v2. Instead the primary mixin is now required: Financial-Times/origami#121
notlee
added a commit
to Financial-Times/origami-build-tools
that referenced
this pull request
May 6, 2021
Origami spec v2 components will require a primary mixin and will no longer recommend the silent mode variable. Related proposal: Financial-Times/origami#121 Related spec suggestion: Financial-Times/origami-website#273 (comment)
notlee
added a commit
to Financial-Times/origami-build-tools
that referenced
this pull request
May 13, 2021
Origami spec v2 components will require a primary mixin and will no longer recommend the silent mode variable. Related proposal: Financial-Times/origami#121 Related spec suggestion: Financial-Times/origami-website#273 (comment)
notlee
added a commit
to Financial-Times/origami-build-tools
that referenced
this pull request
May 13, 2021
Origami spec v2 components will require a primary mixin and will no longer recommend the silent mode variable. Related proposal: Financial-Times/origami#121 Related spec suggestion: Financial-Times/origami-website#273 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👉 view rendered proposal