Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography component tokens #1674

Merged
merged 8 commits into from
May 31, 2024
Merged

Typography component tokens #1674

merged 8 commits into from
May 31, 2024

Conversation

MaryGodservant
Copy link
Contributor

@MaryGodservant MaryGodservant commented May 29, 2024

  • Use use-case tokens directly.
  • Correct link focus styles across ui & editorial typography
  • Delete unused/duplicate tokens
  • Add whitelabel tokens for editorial type

@MaryGodservant MaryGodservant requested a review from a team as a code owner May 29, 2024 16:51
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ May 29, 2024
@notlee notlee temporarily deployed to origami-webs-ui-typogra-myvtpy May 29, 2024 16:55 Inactive
Also uses use-cases rather than component tokens; rebuilds tokens
@notlee notlee temporarily deployed to origami-webs-ui-typogra-myvtpy May 30, 2024 11:48 Inactive
@notlee notlee changed the title UI typography component tokens Typography component tokens May 30, 2024
@notlee notlee added the chromatic Adding chromatic will run visual regression tests label May 30, 2024
@notlee notlee temporarily deployed to origami-webs-ui-typogra-myvtpy May 30, 2024 11:55 Inactive
@notlee notlee temporarily deployed to origami-webs-ui-typogra-myvtpy May 30, 2024 12:31 Inactive
@notlee notlee added chromatic Adding chromatic will run visual regression tests and removed chromatic Adding chromatic will run visual regression tests labels May 30, 2024
@notlee notlee temporarily deployed to origami-webs-ui-typogra-myvtpy May 30, 2024 16:09 Inactive
@notlee notlee requested review from frshwtr and removed request for notlee and a team May 30, 2024 16:40
Copy link
Contributor

@akomiqaia akomiqaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notlee notlee merged commit f04ed53 into main May 31, 2024
11 checks passed
Origami ✨ automation moved this from Backlog to Done May 31, 2024
@notlee notlee deleted the ui-typography-component-tokens branch May 31, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromatic Adding chromatic will run visual regression tests
Projects
Origami ✨
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants