backstage: route branded blog requests to unbranded url #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlee
requested changes
May 31, 2024
There was a problem hiding this comment.
I'm afraid this approach won't work for us:
- We deploy a built, static version, which still 404s
- As discussed, we don't want to lose the users selected brand when switching between the blog and branded content
Static build:
npm run build -w apps/for-everyone-website/
npm run preview -w apps/for-everyone-website/
akomiqaia
approved these changes
Jun 5, 2024
akomiqaia
previously requested changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When a brand is selected, requests to the blog pages resolve to
/<brand>/blog, this doesn't exist, and results in a 404.This change will redirect requests to blog to the unbranded url.
Issue ticket number and link
Link to Figma designs
Checklist before requesting a review
percylabel for o-[COMPONENT] orchromaticlabel for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md