Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new content branding tools to reduce buttons docs #1696

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Use new content branding tools to reduce buttons docs #1696

merged 4 commits into from
Jun 6, 2024

Conversation

notlee
Copy link
Contributor

@notlee notlee commented Jun 6, 2024

See commit messages

@notlee notlee requested a review from a team as a code owner June 6, 2024 15:28
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ Jun 6, 2024
@notlee notlee temporarily deployed to origami-webs-branded-co-l9tmtp June 6, 2024 15:33 Inactive
Base automatically changed from reduce-duplicate-content-pre-req to main June 6, 2024 15:33
@notlee
backstage: Add BrandedContent.astro
fa6e85d 
Conditionally render children according to `brands` and the `currentBrand`.
Even in mdx!

```mdx
<BrandedContent currentBrand={props.brand} brands='core, professional'>

✨Just for you...✨

</BrandedContent>
```
@notlee
chore: remove remark-flexible-containers, this is not used
47f8a2f
@notlee
chore: Add remark plugin to improve branded content authoring experience
f282ff6 
With a little magic:

- Make the `BrandedContent` component avaliable to all md files
- Automatically pass down the current brand.
@akomiqaia
Copy link
Contributor

can we remove the yellow notification that says Do these guidelines differ for your brand? Let us know in #design-system-guild. and mono still seems to appear in the sidebar for different brands

@notlee notlee temporarily deployed to origami-webs-branded-co-l9tmtp June 6, 2024 15:45 Inactive
@notlee
Copy link
Contributor Author

notlee commented Jun 6, 2024

@akomiqaia

  1. Yes. That message is unhelpful
  2. It will for development. That's a downside of this post-processing approach vs. maintaining a fork. Will create a follow up PR with documentation 👍

@notlee notlee merged commit 69b68c2 into main Jun 6, 2024
9 checks passed
Origami ✨ automation moved this from Backlog to Done Jun 6, 2024
@notlee notlee deleted the branded-content-astro branch June 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frshwtr frshwtr frshwtr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Origami ✨
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@notlee @akomiqaia @frshwtr