docs: introduce grid guidelines #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlee
reviewed
Jun 11, 2024
notlee
reviewed
Jun 11, 2024
notlee
reviewed
Jun 11, 2024
|
|
||
| <Guideline summary="Aligning content to grid" do={true}> | ||
| <p slot="description"> | ||
| Create a container around the sub-items in a page e.g ads banners to align with the grid columns, avoid having a |
There was a problem hiding this comment.
I'm struggling to understand what this means, could it be reworded for clarity or perhaps enhanced with a visual aide available?
notlee
approved these changes
Jun 12, 2024
It is a design foundation, not a component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Link to Figma designs
Checklist before requesting a review
percylabel for o-[COMPONENT] orchromaticlabel for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md