docs: Improve typography documentation [OR-730] #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
notlee
commented
Jun 14, 2024
•
notlee
commented
- Use one mdx file, to avoid duplicate content to manage
- Add SV editorial typography guidelines
- Display customisation options and code example
- Place type scales behind tabs, to avoid endless scrolling.
- Show a code snippet with copy button for type scales.
- Use one mdx file, to avoid duplicate content to manage - Add SV editorial typography guidelines - Add a new Preview code snippet to highlight allowed customisations (I do not love that this shows what could be, rather than what is in the demo, but it's the best idea I have for showing this kind of option right now). - Place type scales behind tabs, to avoid endless scrolling. - Show a code snippet with copy button for type scales.
notlee
changed the title
The preview code should show only code for the preview, not hypothetical extras. The customisation options should also be visible to designers
we would not expect any other way for editorial typography
frshwtr
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.