Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tracking and optional links for subscribe link and login link #1732

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

juanSanchezAlcala
Copy link
Contributor

@juanSanchezAlcala juanSanchezAlcala commented Jun 21, 2024

Add tracking and allow to pass links to subscribe and login. In case we don't pass that property the text will be shown without links

ticket

  • I have applied percy label for o-[COMPONENT] or chromatic label for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md
  • If it is a new feature, I have added thorough tests.
  • I have updated relevant docs.
  • I have updated relevant env variables in Doppler.

@juanSanchezAlcala juanSanchezAlcala requested a review from a team as a code owner June 21, 2024 12:08
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ Jun 21, 2024
@notlee notlee temporarily deployed to origami-webs-tracking-a-zhf9di June 21, 2024 12:12 Inactive
@notlee notlee temporarily deployed to origami-webs-tracking-a-izvj2k June 27, 2024 14:16 Inactive
@notlee notlee temporarily deployed to origami-webs-tracking-a-izvj2k June 27, 2024 14:41 Inactive
@debugwand debugwand merged commit 002bb09 into main Jun 28, 2024
9 checks passed
Origami ✨ automation moved this from Backlog to Done Jun 28, 2024
@debugwand debugwand deleted the tracking-and-link-comments branch June 28, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Origami ✨
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants