Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow npm 8 in engines config #456

Merged
merged 3 commits into from Nov 24, 2021
Merged

feat: allow npm 8 in engines config #456

merged 3 commits into from Nov 24, 2021

Conversation

chee
Copy link
Member

@chee chee commented Nov 22, 2021

For our purposes, npm 7 and 8 are the same

closes #453

@chee chee requested a review from a team as a code owner November 22, 2021 12:33
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Nov 22, 2021
@chee chee temporarily deployed to origami-pr-456 November 22, 2021 12:33 Inactive
@JakeChampion JakeChampion temporarily deployed to origami-pr-456 November 22, 2021 14:45 Inactive
@JakeChampion JakeChampion temporarily deployed to origami-pr-456 November 22, 2021 16:51 Inactive
For our purposes, npm 7 and 8 are the same
@JakeChampion JakeChampion temporarily deployed to origami-pr-456 November 24, 2021 16:20 Inactive
…moBuild.sass and demoBuild.js are not undefined
@JakeChampion JakeChampion enabled auto-merge (rebase) November 24, 2021 17:53
@JakeChampion JakeChampion merged commit 984ef0a into main Nov 24, 2021
Origami ✨ automation moved this from incoming to complete Nov 24, 2021
@JakeChampion JakeChampion deleted the engines branch November 24, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Origami ✨
  
Done
Development

Successfully merging this pull request may close these issues.

allow npm 8 in engines
2 participants