Update variable font proposal for a resized MetricWeb #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have discovered that we can only procure a variable font for a resized version of MetricWeb, which is closer in size to system fonts like Arial. A resized Metric is good long term but changes the proposal we were working to and could make it much harder to rollout.
notlee
force-pushed
the
variable-fonts-resized
branch
from
1a2d045
to
2c96017
Compare
| But: | ||
| - Commissioning resized fonts may be expensive. | ||
| - Our typography scale would change, and there may be a different scale per font. The design team would have to use these new fonts and remember the scale has changed. Products which use `o-typography` mixins to set font size would not need to make any changes, however anywhere an engineer has used `font-size` directly would need to be updated, else render smaller than it should. | ||
| To use the resized MetricWeb we will need to update our typographic scale, so when MetricWeb is output it visually looks unchanged. That means we would need two scales, one for MetricWeb and one for Financier. The design team would have to use the resized font and remember the scale has changed. Products which use `o-typography` mixins to set font size would not need to make any changes, however anywhere an engineer has used `font-size` directly would need to be updated, else render smaller than it should. This could arguably be a minor release but practically should be a major release to allow users to replace `font-size`/`line-height` declarations with `o-typography` mixin calls. |
There was a problem hiding this comment.
Is it possible to do a search across the ft github and find out how many font-size/line-height declarations are being used with the fonts?
JakeChampion
approved these changes
Nov 30, 2020
|
Moved to issue: #240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have discovered that we can only procure a variable font for a
resized version of MetricWeb, which is closer in size to system
fonts like Arial.
A resized Metric is good long term but changes the proposal we
were working to and could make it much harder to rollout.