Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formdata #677

Closed
wants to merge 2 commits into from
Closed

Formdata #677

wants to merge 2 commits into from

Conversation

isocroft
Copy link

This PR enables the FormData constructor and instance APIs (e.g. set(), keys(), entries() ) using a polyfill located here

@isocroft isocroft requested a review from a team as a code owner June 25, 2020 10:55
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@isocroft isocroft mentioned this pull request Jun 25, 2020
firefox_mob = "<45"
safari = "<12"
ie = "<11"
opera = "<15"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @isocroft.

This currently does not use/install the polyfill. To install the polyfill we need to declare it like this:

Suggested change
opera = "<15"
opera = "<15"
[install]
module = "formdata-polyfill"
paths = [ "formdata.min.js" ]

We will also need to add it as a dependency to the package.json file by running npm i formdata-polyfill and updating the .gitignore and .eslintignore files to include polyfills/FormData/polyfill.js.

We also want to add some tests in polyfills/FormData/tests.js to prove the polyfill works correctly in all the browsers.

@JakeChampion
Copy link
Owner

Closing this in favour of #668 where the conversation and work seems to be progressing

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants