-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nextElementSibling and previousElementSibling polyfills #484
Add nextElementSibling and previousElementSibling polyfills #484
Conversation
7c40b4d
to
ddda187
Compare
@JakeChampion think this is ready for another review, I believe the tests have not run since I'm an external contributor and don't have access to secure credentials? I've also left a question about |
Tests are now running on CircleCI :-) Thank you for the pull request! |
A wider |
Thanks for sorting those issues for me 👍 |
@NickColley Thank you so much for contributing these polyfills! They will be in the next release :-) |
Raising this to see if I'm on the right track.
Do we need to polyfill CharacterData?
So it looks like this feature is used in the node type of
NonDocumentTypeChildNode
since it can beElement
andCharacterData
. Does this block this improvement, or can we continue and consider a widerNonDocumentTypeChildNode
polyfill later that would also sort CharacterData?Closes #338