Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextElementSibling and previousElementSibling polyfills #484

Merged

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented Feb 24, 2020

Raising this to see if I'm on the right track.

Do we need to polyfill CharacterData?

So it looks like this feature is used in the node type of NonDocumentTypeChildNode since it can be Element and CharacterData. Does this block this improvement, or can we continue and consider a wider NonDocumentTypeChildNode polyfill later that would also sort CharacterData?

Closes #338

@claassistantio
Copy link

claassistantio commented Feb 24, 2020

CLA assistant check
All committers have signed the CLA.

@NickColley NickColley changed the title Add next previous element sibling Add nextElementSibling and previousElementSibling polyfills Feb 24, 2020
@NickColley NickColley force-pushed the add-next-previous-element-sibling branch from 7c40b4d to ddda187 Compare February 24, 2020 17:27
@NickColley NickColley marked this pull request as ready for review February 24, 2020 17:41
@NickColley
Copy link
Contributor Author

@JakeChampion think this is ready for another review, I believe the tests have not run since I'm an external contributor and don't have access to secure credentials?

I've also left a question about CharacterData in the main pull request description I'm not sure about.

@JakeChampion
Copy link
Owner

Tests are now running on CircleCI :-) Thank you for the pull request!

@JakeChampion
Copy link
Owner

Do we need to polyfill CharacterData?

So it looks like this feature is used in the node type of NonDocumentTypeChildNode since it can be Element and CharacterData. Does this block this improvement, or can we continue and consider a wider NonDocumentTypeChildNode polyfill later that would also sort CharacterData?

A wider NonDocumentTypeChildNode can be added later 👍

@JakeChampion JakeChampion merged commit 9f05e0e into JakeChampion:master Feb 25, 2020
@NickColley
Copy link
Contributor Author

Thanks for sorting those issues for me 👍

@NickColley NickColley deleted the add-next-previous-element-sibling branch February 25, 2020 09:08
@JakeChampion
Copy link
Owner

@NickColley Thank you so much for contributing these polyfills! They will be in the next release :-)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nextElementSibling, previousElementSibling polyfills
3 participants