Update vendor polyfills to match upstream #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have contributed these [polyfills back upstream to polyfill-library](https://github.com/Financial-Times/polyfill-library/pull/484/files). Removes Immediately Invoked Function Expression [IFFE](https://developer.mozilla.org/en-US/docs/Glossary/IIFE) as it's not required since there's no reference to 'global' and the overall file has an IFFE. Updates links to the upstream repository.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1745
|
Going to do a sanity check of the removal of the 'global' IFFE in browser stack to double check. Edit: Tabs still work as expected in IE8 without any script errors. |
36degrees
approved these changes
Feb 25, 2020
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| ### Fixes | |||
|
|
|||
| - [Pull request #1745: Update vendor polyfills to match upstream](https://github.com/alphagov/govuk-frontend/pull/1745). | |||
There was a problem hiding this comment.
Do we think this is useful for users to have this in the release notes, as it's mostly an internal change?
There was a problem hiding this comment.
I err on the side of strict most of the time, we'd probably get away with not having an entry though. Up to you.
There was a problem hiding this comment.
I have no particular preference, was just unsure about it myself. Maybe @m-green can look at this when we come to cut the next release.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have contributed these polyfills back upstream to
polyfill-library.
Removes Immediately Invoked Function Expression IFFE
as it's not required since there's no reference to 'global' and the
overall file has an IFFE.
Updates links to the upstream repository.