partial tests in ci #997
Merged
partial tests in ci #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Feb 21, 2021
| @@ -172,6 +172,6 @@ module.exports = class TestJob { | |||
| } | |||
|
|
|||
| get configForLog() { | |||
| return `${this.mode.padEnd(" ", 8)} / ${(this.polyfillCombinations ? 'combined' : ' ')} / ${(this.shard ? 'shard ' + this.shard + ' ' : 'shard n/a')}`; | |||
| return `${this.mode.padEnd(" ", 8)} / ${(this.polyfillCombinations ? 'combined' : ' ')}${(this.shard ? ' / shard ' + this.shard + ' ' : '')}`; | |||
There was a problem hiding this comment.
Only IE8/9 need this, for all other tests it just bloats the logs.
|
@JakeChampion Also added some unit tests to validate the logic and at this point I am generally happy with the state of this change. |
JakeChampion
requested review from
JakeChampion
and removed request for
a team
romainmenke
deleted the
partial-tests-in-ci--resourceful-discus-47b0e9c63b
branch
This was referenced Feb 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for tests in CI :
master.mastercontains few changes only inpolyfills/....1 : Scheduled job for polyfill combinations.
These tests are still valuable as they revealed a lot of issues initially.
New errors however are rare and these tests should just guard against issues creeping in over time.
Testing once a week on master should be sufficient to keep the codebase healthy.
The caching mechanism in place to speed up retries will also help here.
If there were no changes in the past week this job will skip each step.
2 : Partial tests.
test-modified-onlyis used as an argument fornode ./test/polyfills/remotetest.js.masteronhttps://github.com/Financial-Times/polyfill-library.gitIt doesn't take
origin/masterto make it easier for contributors who fork and open pr's. Their CI should not test against their ownmasterbut againstupstream/masterNotes :
This is a rather big change and I would like to revisit it in the next couple of days with fresh eyes.
Any feedback in the mean time is more than welcome!
If there is a reason not to implement a feature like this at all, that is totally fine too! 🙂
This PR would be a good validation of this change as it's only needed in a few old browser : #991