Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigator.sendBeacon does not fail silently #523

Closed
jackmellis opened this issue Mar 3, 2020 · 1 comment · Fixed by #524
Closed

navigator.sendBeacon does not fail silently #523

jackmellis opened this issue Mar 3, 2020 · 1 comment · Fixed by #524

Comments

@jackmellis
Copy link

Bug

What

If sendBeacon fails to send fails silently. The polyfilled version throws an error.
This came out of testing an app that was sending google analytics directly via sendBeacon. A user had IE11 set to strict privacy, which blocked the request. The sendBeacon polyfill threw an error which caused the entire page to crash

Details

This came out of testing an app that was sending google analytics directly via sendBeacon.
A user had IE11 set to strict privacy, which blocked the request. The sendBeacon polyfill threw an error which caused the entire page to crash
JakeChampion referenced this issue Mar 3, 2020
@JakeChampion
If navigator.sendBeacon can not queue the work for transferring, retu…
452d18b 
…rn false as per the specification.

Fixes https://github.com/Financial-Times/polyfill-service/issues/2160
@JakeChampion JakeChampion transferred this issue from polyfillpolyfill/polyfill-service Mar 3, 2020
@JakeChampion JakeChampion mentioned this issue Mar 3, 2020
Merged
@JakeChampion
Copy link
Owner

Hi @jackmellis, thank you for the good issue here :-)

The pull-request to fix this issue is #524 👍

Origami ✨ automation moved this from incoming to complete Mar 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2020
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JakeChampion @jackmellis