Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/uppsf 864 temp hide hasbrand #48

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Conversation

epavlova
Copy link
Contributor

@epavlova epavlova commented Nov 7, 2019

No description provided.

@epavlova epavlova requested a review from a team November 7, 2019 08:10
annotations/models.go Show resolved Hide resolved
Copy link
Contributor

@MiroslavGatsanoga MiroslavGatsanoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we missed when adding the linters step is to pass --build-tags=integration so that the linters run on the files marked with this build tag.

@epavlova epavlova force-pushed the fix/UPPSF-864-temp-hide-hasbrand branch from b511249 to 97c50d5 Compare November 11, 2019 08:17
@epavlova epavlova force-pushed the fix/UPPSF-864-temp-hide-hasbrand branch from aabee13 to b9f8320 Compare November 11, 2019 09:35
@epavlova epavlova merged commit f2ca509 into master Nov 12, 2019
@epavlova epavlova deleted the fix/UPPSF-864-temp-hide-hasbrand branch November 12, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants