Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix external authorities handling #60

Merged
merged 2 commits into from Mar 5, 2024
Merged

fix external authorities handling #60

merged 2 commits into from Mar 5, 2024

Conversation

ManoelMilchev
Copy link
Contributor

Description

What

Return proper authorityValue for external concepts.

Why

JIRA

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

DoD - Ensure all relevant tasks are completed before marking this PR as "Ready for review"

  • Test coverage is not significantly decreased
  • All PR checks have passed
  • Changes are deployed on dev before asking for review
  • Documentations remains up-to-date
    • OpenAPI definition file is updated
    • README file is updated
    • Documentation is updated in upp-docs and upp-public-docs
    • Architecture diagrams are updated

This Pull Request follows the rules described in our Pull Requests Guide

@ManoelMilchev ManoelMilchev requested a review from a team as a code owner February 28, 2024 15:53
angelraynovft
angelraynovft previously approved these changes Feb 29, 2024
View reviewed changes
@angelraynovft angelraynovft requested a review from a team February 29, 2024 10:25
agrancharova
agrancharova previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@agrancharova agrancharova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discuss, let's release it this way, and take the ontology improvement as a separate task.

@agrancharova agrancharova requested a review from a team February 29, 2024 11:29
@agrancharova agrancharova requested a review from a team February 29, 2024 14:11
@ManoelMilchev ManoelMilchev merged commit 04d539f into master Mar 5, 2024
5 checks passed
@ManoelMilchev ManoelMilchev deleted the fix/UPPSF-4958-make-the-service-work-with-external-authorities branch March 5, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelraynovft angelraynovft angelraynovft approved these changes

@agrancharova agrancharova agrancharova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ManoelMilchev @angelraynovft @agrancharova