Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s improvements #17

Merged
merged 2 commits into from Jan 22, 2018
Merged

K8s improvements #17

merged 2 commits into from Jan 22, 2018

Conversation

bogdanguranda
Copy link

Parallel GTG, timed healthcheck.
Helm: pod anti-affinity, memory requests and limit.

@@ -10,7 +10,9 @@ image:
pullPolicy: IfNotPresent
cache_duration: 10m
resources:
requests:
memory: 12Mi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have seen spikes of just shy of 60MB. If we say we can move to a instance with at least 12Mi it means we potentially could loose a pod if it spiked as there might not be enough memory on that instance to accomodate that spike? This is a public facing API where any outage is client facing so it would probably be better to air on the side of caution and request enough to deal with a spike???? Other applications I would be less concerned about

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question. I am not aware how fast the app would be able to request for more memory? I though it would be able to handle such spikes. The biggest spike I see in the last 30 days is 30 MB, I would increase the initial request to this, though this would mean more memory than average needed, but this amounts are small either way.

Adjusted memory requests and limit.
@SCBbestof SCBbestof merged commit 8d6d25f into master Jan 22, 2018
@SCBbestof SCBbestof deleted the fix/k8s-hc-helm branch January 22, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants