Upgrade gorilla handlers package to v1.3.0 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karsov
reviewed
Mar 11, 2020
|
The load test was not being run as part of the CI workflow since it was added to the file two and a half years ago, so I don't see any value in keeping it. And also the service should be deprecated at some point anyway in favour of |
karsov
previously approved these changes
Mar 11, 2020
MiroslavGatsanoga
force-pushed
the
fix/UPPSF-1178-upgrade-gorilla-handlers
branch
from
16345f7
to
c4c056a
Compare
ivan-p-nikolov
approved these changes
Mar 13, 2020
karsov
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also migrate the project to modules and using the golang-ci orb.