Do not warn on 403 received from S3 buckets.

publishCheck.go

@@ -185,7 +185,10 @@ func (s S3Check) isCurrentOperationFinished(pc *PublishCheck) (operationFinished
 	defer cleanupResp(resp)
 
 	if resp.StatusCode != 200 {
-		log.Warnf("Checking %s. Error calling URL: [%v] : Response status: [%v]", loggingContextForCheck(pm.config.Alias, pm.UUID, pm.platform, pm.tid), url, resp.Status)
+		/*	for S3 files, we're getting a 403 if the files are not yet in, so we're not warning on that */
+		if resp.StatusCode != 403 {
+			log.Warnf("Checking %s. Error calling URL: [%v] : Response status: [%v]", loggingContextForCheck(pm.config.Alias, pm.UUID, pm.platform, pm.tid), url, resp.Status)
+		}
 		return false, false
 	}
 

publishCheck_test.go

@@ -49,6 +49,14 @@ func TestIsCurrentOperationFinished_S3Check_NotFinished(t *testing.T) {
 	assert.False(t, finished, "operation should not have finished")
 }
 
+func TestIsCurrentOperationFinished_S3Check_NotFinished_On_403(t *testing.T) {
+	s3Check := &S3Check{
+		mockHTTPCaller(t, "", buildResponse(403, "")),
+	}
+	finished, _ := s3Check.isCurrentOperationFinished(NewPublishCheck(PublishMetric{}, "", "", 0, 0, nil))
+	assert.False(t, finished, "operation should not have finished")
+}
+
 func TestIsCurrentOperationFinished_ContentCheck_InvalidContent(t *testing.T) {
 	currentTid := "tid_1234"
 	testResponse := `{ "uuid" : "1234-1234"`