Content carousel support #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 1, 2017 15:22
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 13 13
Lines 461 461
=======================================
Hits 379 379
Misses 60 60
Partials 22 22
Continue to review full report at Codecov.
|
peteclark-ft
approved these changes
Mar 1, 2017
app_test.go
Outdated
| if !isIgnorableMessage(syntheticTID) { | ||
| t.Error("Synthetic message marked as normal") | ||
| } | ||
| if !isIgnorableMessage(carouselRepublishTID) { | ||
| t.Error("Courousel republish message marked as normal") |
app_test.go
Outdated
| t.Error("Courousel republish message marked as normal") | ||
| } | ||
| if !isIgnorableMessage(carouselGeneratedTID) { | ||
| t.Error("Courousel generated message marked as normal") |
kghatton
reviewed
Mar 2, 2017
LICENSE
Outdated
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2016 Financial Times | |||
app.go
Outdated
| return strings.HasPrefix(tid, "SYNTHETIC") | ||
| } | ||
|
|
||
| var carouselTransactionIDRegExp = regexp.MustCompile(`^(tid_[\S]+)_carousel_[\d]{10}.*$`) |
There was a problem hiding this comment.
I'd prefer all the declarations at the top of the file. Also I wonder whether this should be ^(tid_[^_]+)_...
kghatton
approved these changes
Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: