Configuring PAM for K8S prod #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tamas-molnar
commented
Nov 24, 2017
•
tamas-molnar
commented
- moved read env config to global-configs -see https://github.com/Financial-Times/upp-global-configs/pull/21
- set base url for validation
- for production envs: manually in the app-config
- for team envs: read from deployment param (depends on Jenkins job feature)
- added PAM secrets for production, see lastpass
- updated secrets in K8S CT
tosan88
approved these changes
Nov 24, 2017
sbuliarca
reviewed
Nov 24, 2017
| @@ -65,20 +65,21 @@ spec: | |||
| secretKeyRef: | |||
| name: publish-availability-monitor-secrets | |||
| key: notifications_push.api_key | |||
| {{- $base_url := default .Values.envs.validation_endpoints.base_url .Values.cluster.delivery.url }} | |||
There was a problem hiding this comment.
I was wrong on this one.. the parameters should be inverted.
sbuliarca
approved these changes
Nov 27, 2017
sbuliarca
reviewed
Nov 28, 2017
| @@ -20,7 +20,5 @@ envs: | |||
| methode_article_internal_components_mapper: "__methode-article-internal-components-mapper/map" | |||
| video_mapper: "__upp-next-video-mapper/map" | |||
| wordpress_mapper: "__wordpress-article-mapper/map" | |||
| base_url: "https://upp-k8s-delivery-test-eu.ft.com/" | |||
| base_url: "http://upp-prod-delivery.ft.com/" | |||
tosan88
reviewed
Nov 29, 2017
| # I had to split the URL into 2 parts because I couldn't find a way to put the exact string \& in the value | ||
| # This way I moved handling that value in the template chart where it seems it doesn't have a problem with it. | ||
| notifications_push_url: "/content/notifications-push?monitor=true" | ||
| notifications_pursh_url_param2: "type=all" |
tosan88
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.