🐛 Stopping the cycle mid-load should not make the cycle be unhealthy

Financial-Times · Jun 1, 2017 · 02907d2 · 02907d2
1 parent 96e70f4
commit 02907d2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/native/in_memory_collection.go b/native/in_memory_collection.go
@@ -37,7 +37,7 @@ func LoadIntoMemory(ctx context.Context, uuidCollection UUIDCollection, collecti
 	for {
 		if ctx.Err() != nil {
 			log.WithError(ctx.Err()).Warn("Interrupting cursor load due to cycle stop.")
-			return it, ctx.Err()
+			return it, nil
 		}
 
 		finished, uuid, err := uuidCollection.Next()

diff --git a/native/in_memory_collection_test.go b/native/in_memory_collection_test.go
@@ -131,8 +131,7 @@ func TestLoadIntoMemoryWithContextInterrupt(t *testing.T) {
 	go func() {
 		defer wg.Done()
 		_, err := LoadIntoMemory(ctx, uuidCollection, "collection", 0, noopBlacklist)
-		assert.Error(t, err)
-		assert.Equal(t, "context canceled", err.Error())
+		assert.NoError(t, err)
 
 		completed = true
 	}()