This repository has been archived by the owner on May 23, 2024. It is now read-only.
Archive cycle race condition fix + other fixes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 5, 2017 16:10
peteclark-ft
approved these changes
Apr 13, 2017
| @@ -139,10 +139,6 @@ func (s *DefaultReadWriter) GetLatestKeyForID(id string) (string, error) { | |||
| return latestKey, nil | |||
| } | |||
|
|
|||
| func getPrefixForID(id string) string { | |||
There was a problem hiding this comment.
Haha - yes this was a bit redundant. There was originally a prefix, but I removed it (and left this) 💩
kghatton
approved these changes
Apr 13, 2017
| assert.Len(t, c.State(), 1, "The cycle should have one state") | ||
| assert.Contains(t, c.State(), startingState, "Cycle should be in running state") | ||
|
|
||
| time.Sleep(2 * time.Second) |
There was a problem hiding this comment.
I wonder whether these tests should be skipped by -short as they cumulatively sleep for several seconds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.