Feature/content package #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bogdanguranda
commented
Mar 17, 2017
•
bogdanguranda
commented
- Added content-package support.
- Added UT and IT tests for content package.
- Update README.md
- Added vendoring.
added 10 commits
February 23, 2017 16:07
# Conflicts: # relations/cypher.go
# Conflicts: # relations/cypher.go
…ntent as node labels. Added integration tests that are commented until content-collection-rw-neo4j is in production.
kovacshuni
approved these changes
Mar 17, 2017
radutudor
approved these changes
Mar 20, 2017
Nesze
reviewed
Mar 20, 2017
relations/cypher.go
Outdated
| neoCRC := []neoRelatedContent{} | ||
| //neo content package contained contents | ||
| neoCPCC := []neoRelatedContent{} |
There was a problem hiding this comment.
I think it would be better if the naming remain consistent in the different vars (e.g. neoCPCC vs cpcQuery vs mappedCPC.
relations/cypher_integration_test.go
Outdated
| assert.Equal(t, len(expectedResponse.CuratedRelatedContents), len(actualCRC.CuratedRelatedContents), "Didn't get the same number of curated related content") | ||
| assertListContainsAll(t, actualCRC.CuratedRelatedContents, expectedResponse.CuratedRelatedContents) | ||
| } | ||
|
|
||
| //func TestRetrieveContainsContent(t *testing.T) { |
There was a problem hiding this comment.
Commenting this out... I guess it's not deliberate.
Edit: just read the task description, ignore this.
bogdanguranda
force-pushed
the
feature/content-package
branch
from
f5965e2
to
0b87e1c
Compare
Nesze
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.