Fix/uppsf 2909 remove neoutils #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManoelMilchev
requested changes
Dec 17, 2021
.circleci/config.yml
Outdated
| @@ -10,7 +10,7 @@ workflows: | |||
| name: build-and-test-project | |||
| executor-name: | |||
| name: ft-golang-ci/default-with-neo4j | |||
| neo4j-image-version: 3.5.28-enterprise | |||
| neo4j-image-version: 4.3.6-enterprise | |||
There was a problem hiding this comment.
nitpick: We can remove the explicit neo4j-image-version as our circleci executor default-with-neo4j version is the same.
docker-compose-tests.yml
Outdated
| command: [ "go", "test", "-mod=readonly", "-tags=integration" , "./..." ] | ||
| depends_on: | ||
| - neo4j | ||
| neo4j: | ||
| image: neo4j:3.5.28-enterprise | ||
| image: neo4j:3.4.6-enterprise |
There was a problem hiding this comment.
issue: I think that you mistyped the image version. The version that we are looking for is 4.3.6-enterprise.The tests wont execute with the current 3.4.6-enterprise version.
docker-compose-tests.yml
Outdated
| @@ -10,13 +10,12 @@ services: | |||
| GITHUB_USERNAME: "${GITHUB_USERNAME}" | |||
| GITHUB_TOKEN: "${GITHUB_TOKEN}" | |||
| environment: | |||
| - NEO4J_TEST_URL=http://neo4j:7474 | |||
| - NEO4J_BOLT_TEST_URL=bolt://neo4j:7687 | |||
| - NEO4J_TEST_URL=bolt://neo4j:7687 | |||
| command: [ "go", "test", "-mod=readonly", "-tags=integration" , "./..." ] | |||
There was a problem hiding this comment.
suggestion: Can we add the verbose flag please.
Suggested change
| command: [ "go", "test", "-mod=readonly", "-tags=integration" , "./..." ] | |
| command: [ "go", "test", "-v", "-mod=readonly", "-tags=integration" , "./..." ] |
mchompalova
force-pushed
the
fix/UPPSF-2909-remove-neoutils
branch
from
e8efdbc
to
59ba74f
Compare
mchompalova
force-pushed
the
fix/UPPSF-2909-remove-neoutils
branch
from
1950f71
to
83217e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What
We removed the dependency on neo-utils-go from the project.
Why
https://financialtimes.atlassian.net/browse/UPPSF-2909
Scope and particulars of this PR (Please tick all that apply)
This Pull Request follows the rules described in our Pull Requests Guide