Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runbook #30

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Add runbook #30

merged 2 commits into from
Jul 2, 2020

Conversation

dbelev
Copy link
Contributor

@dbelev dbelev commented Jul 2, 2020

Description

What

Please be specific and try to describe your thought process. State the obvious, since this might be the first time the reviewer is looking at the code

Why

Copy (if there is one) the text of the original Trello/JIRA ticket in here, with a link back to it for the curious.

Anything, in particular, you'd like to highlight to reviewers

Mention here sections of code which you would like reviewers to pay extra attention to .E.g

Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

This Pull Request follows the rules described in our Pull Requests Guide


Available checks reveal the status of S3 and Splunk connectivity.

2. Check the [log collector](https://dewey.in.ft.com/view/system/log-collector#troubleshooting) for any issues in storing log messages in S3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Check the [log collector](https://dewey.in.ft.com/view/system/log-collector#troubleshooting) for any issues in storing log messages in S3.
2. Check the [log collector](https://biz-ops.in.ft.com/System/log-collector#troubleshooting) for any issues in storing log messages in S3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@coveralls
Copy link

Pull Request Test Coverage Report for Build 286

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.413%

Totals Coverage Status
Change from base Build 280: 0.0%
Covered Lines: 370
Relevant Lines: 504

💛 - Coveralls

@dbelev dbelev merged commit 971d836 into master Jul 2, 2020
@dbelev dbelev deleted the fix/UPPSF-1181-add-runbook branch July 2, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants