Feature/migrate to iam serviceaccount #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update go version Replace ioutil with io
Pull Request Test Coverage Report for Build 406
💛 - Coveralls |
ivanruski
force-pushed
the
feature/migrate_to_iam_serviceaccount
branch
3 times, most recently
from
7ea4628
to
ccdc578
Compare
If deleting an object in s3 fail, it won't be reported in the error returned from `svc.DeleteObjects`, instead it will be reported in the output object returned from the same method.
ivanruski
force-pushed
the
feature/migrate_to_iam_serviceaccount
branch
from
ccdc578
to
b61abd2
Compare
ivanruski
force-pushed
the
feature/migrate_to_iam_serviceaccount
branch
from
b61abd2
to
a3df679
Compare
The service access buckets which are in eu-west-1, however when the service is deployed in us the AWS_REGION envvars is set to us-east-1(because of the IAM to ServiceAccount feature).
ivanruski
approved these changes
Nov 29, 2022
| merr = multierr.Append(merr, fmt.Errorf("deleting %q: %s", *e.Key, *e.Code)) | ||
| } | ||
|
|
||
| return nil, err |
There was a problem hiding this comment.
question: Shouldn't this be merr?
Suggested change
| return nil, err | |
| return nil, merr |
dbelev
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What
Please be specific and try to describe your thought process. State the obvious, since this might be the first time the reviewer is looking at the code
Why
https://financialtimes.atlassian.net/browse/UPPSF-3600
Anything, in particular, you'd like to highlight to reviewers
Mention here sections of code which you would like reviewers to pay extra attention to .E.g
Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x
Scope and particulars of this PR (Please tick all that apply)
This Pull Request follows the rules described in our Pull Requests Guide