Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating pac prod keys #45

Merged
merged 2 commits into from Feb 3, 2023
Merged

Rotating pac prod keys #45

merged 2 commits into from Feb 3, 2023

Conversation

ilian2233
Copy link
Contributor

@ilian2233 ilian2233 commented Feb 3, 2023

Description

What

Why

Rotation of HEX keys

slack conversation

Anything, in particular, you'd like to highlight to reviewers

Mention here sections of code which you would like reviewers to pay extra attention to .E.g

Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

This Pull Request follows the rules described in our Pull Requests Guide

@ilian2233 ilian2233 requested a review from a team as a code owner February 3, 2023 13:35
@coveralls
Copy link

coveralls commented Feb 3, 2023

Pull Request Test Coverage Report for Build 445

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 72.674%

Files with Coverage Reduction New Missed Lines %
splunk.go 5 88.14%
Totals Coverage Status
Change from base Build 441: 0.4%
Covered Lines: 375
Relevant Lines: 516

💛 - Coveralls

@ilian2233 ilian2233 merged commit d26a6a3 into master Feb 3, 2023
@ilian2233 ilian2233 deleted the rotating-pac-prod-keys branch February 3, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants