This repository has been archived by the owner on Oct 18, 2021. It is now read-only.
Use the CMDB v3 /items/system endpoint #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GeoffThorpeFT, not sure if you want to look over this |
lib/fetch-system-codes.js
Outdated
| // We're only interested in system codes | ||
| return response.body | ||
| .filter(entry => entry.systemCode) | ||
| .map(entry => entry.systemCode); | ||
| }) |
There was a problem hiding this comment.
I assume the above is aiming to extract just the field named "systemCode" from the rather long list of fields returned by the v3/items/system call. However, due to a legacy issue with data uploads (too long to explain) the systemcode is actually held in the key field "dataItemID" not "systemCode". You may find some "systemCode" fields but its no longer used.
There was a problem hiding this comment.
Excellent, thanks Geoff! Glad I asked :) will change
test/unit/lib/fetch-system-codes.js
Outdated
| {value: 'bar'} | ||
| {systemCode: 'foo'}, | ||
| {noSystemCode: 'this should not appear'}, | ||
| {systemCode: 'bar'} | ||
| ] |
There was a problem hiding this comment.
Due to above issue with the "systemCode" field I recommend changing these mockups to populate "dataItemID" since that is the real system code field.
As @GeoffThorpeFT mentioned, systemCode is no longer used. We now get a more complete list of codes by using dataItemId.
GeoffThorpeFT
approved these changes
Apr 27, 2017
JakeChampion
approved these changes
Apr 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had to switch endpoints for the move from v2 to v3 of CMDB. The intention is to support filtering in the URL at a later date which may mean we can increase the per-page limit and only request the data we need.