Initial impl #2
Initial impl #2
Conversation
- added interval query param - implemented healthcheck
no more 404
Add saving method for splunk health check and http calls with retries
…t-reader into initial-impl
handler.go
Outdated
| switch err { | ||
| case nil: | ||
| writer.WriteHeader(http.StatusOK) | ||
| msg, _ := json.Marshal(transactions) |
There was a problem hiding this comment.
I think the marshall error should not be ignored.
handler.go
Outdated
| switch err { | ||
| case nil: | ||
| writer.WriteHeader(http.StatusOK) | ||
| msg, _ := json.Marshal(*publishEvent) |
splunk_service.go
Outdated
|
|
||
| func (service *splunkService) GetTransactions(query monitoringQuery) ([]transactionEvent, error) { | ||
|
|
||
| envRegex := regexp.MustCompile("-u[ks]]$") |
splunk_service.go
Outdated
|
|
||
| func (service *splunkService) GetLastEvent(query monitoringQuery) (*publishEvent, error) { | ||
|
|
||
| envRegex := regexp.MustCompile("-u[ks]]$") |
|
Changes Unknown when pulling 8d54f35 on initial-impl into ** on master**. |
|
Changes Unknown when pulling a6b5117 on initial-impl into ** on master**. |
|
Changes Unknown when pulling 26972c5 on initial-impl into ** on master**. |
|
Changes Unknown when pulling 8e01558 on initial-impl into ** on master**. |
main.go
Outdated
| }) | ||
| splunkURL := app.String(cli.StringOpt{ | ||
| Name: "splunk-url", | ||
| Desc: "Splunk URL", |
There was a problem hiding this comment.
Maybe describe this a bit more in detail - like: Splunk Rest API url?
|
Changes Unknown when pulling 4a92247 on initial-impl into ** on master**. |
|
|
||
| Response example: | ||
| ``` | ||
| [{ |
There was a problem hiding this comment.
Can you please update the example? (eventcount, publish_start)
README.md
Outdated
| ### Logging | ||
|
|
||
| * The application uses [logrus](https://github.com/Sirupsen/logrus); the log file is initialised in [main.go](main.go). | ||
| * Logging requires an `env` app parameter, for all environments other than `local` logs are written to file. |
|
Changes Unknown when pulling 95f946d on initial-impl into ** on master**. |
|
Changes Unknown when pulling 443ca0e on initial-impl into ** on master**. |
No description provided.