This repository has been archived by the owner on Oct 25, 2021. It is now read-only.
Fix submit on enter for relationship input #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…- preventDefault from running - which caused form submit on input selection
Leigan0
commented
May 18, 2020
…inancial-Times/treecreeper into stop-form-submit-on-relationship-entry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Bug Fix ticket
Create a child record at /ChildType/create
Go to the edit page for a MainType record and in the children field type the child's code - hopefully there will only be a single item in the autocomplete list
Press enter
Expected - Adds a row below the input contain the child record and clears the input and autocomplete
Actual behaviour - Adds a row below the input contain the child record and submits the entire form
What?
event.stopImmediatePropagation();is not a function on keypress event so it stopped the prevent defaultScreenshots / Images
Before