Feature/uppsf 457 fix json failure #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epavlova
approved these changes
Jun 5, 2019
karsov
previously requested changes
Jun 5, 2019
epavlova
previously approved these changes
Jun 6, 2019
Refactor buildHealthcheckJSONResponse function to use utility handleResponseWriterErr function for logging error when writing in body stream fails. Update lock file with latest dependecies ensuring consistent dep ensure.
mitagg
dismissed
karsov’s stale review
The requested change is already implemented and it is tested in the dev cluster
MiroslavGatsanoga
approved these changes
Jun 26, 2019
atanaskuzmanov-ft
approved these changes
Jun 26, 2019
|
stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduced https://github.com/Financial-Times/up-failures/blob/master/2019/2019-06-01-upp-aggregate-healthcheck-failure.md
with giving the service a bit of load pressure.
Checked the json for some wrong formats, but couldn't find such.
Tried to separate json building from sending over the wire for better troubleshooting and couldn't reproduce it anymore. My assumption is there was network related problem while simultaneously converting to json and writing to response buffer.
I'v also removed the explicit panic.
Lets test this in staging for few days.
@karsov @epavlova FYI