Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete payload id -> uuid #20

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

georgi-denchew
Copy link
Contributor

Description

What

The mapper now expects that the payload contains an uuid attribute instead of an id attribute.

Why

In order for the cm-content-deleter to be able to use upp-content-validation-kit it must receive uuid in the payload, therefore we modified the cms-notifier to send it in the payload, hence, the mapper needs to change as well so that it recognizes the payload as valid.

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

This Pull Request follows the rules described in our Pull Requests Guide

@georgi-denchew georgi-denchew requested review from a team January 6, 2021 10:24
ekaneva
ekaneva previously approved these changes Jan 6, 2021
@ekaneva ekaneva requested a review from a team January 6, 2021 12:54
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 57.346% when pulling ede4785 on feature/UPPSF-1994-delete-payload-changes into 30af223 on master.

@georgi-denchew georgi-denchew merged commit 258ba5c into master Jan 7, 2021
@georgi-denchew georgi-denchew deleted the feature/UPPSF-1994-delete-payload-changes branch January 7, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants