Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your runbooks.yaml file is probably no longer needed #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bot-tooling
Copy link

@Financial-Times/universal-publishing

Recent changes to RUNBOOK.md mean you probably don't need these rules:

updateOnMerge and updateBranch - if these were just set up to update
on merge to your default branch there is no need for them any more. RUNBOOK.md
does this by default.

disabled: false and failOn: 'any' - again this is the default behaviour so
is not needed.

systemCodes map - you probably have ## Code defined within each of your
runbooks now, or have the code as part of the file name for each runbook, so
defining it in the yaml config is unnecessary duplication. Even if you don't have this,
it's recommended that you switch to defining codes in your runbook files as it is
easier to keep track of.
More details on system code derivation

Please merge this PR if your runbooks.yaml contains only the rules listed above.
If there are any other rules in it you wish to keep, close this PR and create a
new one that only removes the rules you don't need.

Many thanks

#engineering-insights

@bot-tooling bot-tooling requested a review from a team as a code owner March 18, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant