This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Fix s3 pause/continue chunked multiple bug. #1796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2017 11:34
Reproduce:
s3.XhrUploadHandler
options:
, chunking: { enabled: true, concurrent: { enabled: true } }
, maxConnections: 3
, multiple: true
, resume: { enabled: true}
Chrome: Version 56.0.2924.87 (64-bit)
Begin uploading a large file. Pause and continue the upload a few times
and notice that immediately or eventually (it's sporadic) the upload will
be paused but chunks will still upload in the background.
Solution: the paused state is not cleared on upload continue. initHeaders
promise success seems to be called even though the XHR is aborted. Added
file status pause check here to prevent an XHR PUT when file hsa been
paused.
This is handy since we can know what percentage is uploaded by loaded/size. Useful to initialise progress bars for resumable files.
rnicholus
reviewed
Mar 21, 2017
| @@ -118,7 +118,8 @@ qq.XhrUploadHandler = function(spec) { | |||
| name: uploadData.name, | |||
| remaining: uploadData.chunking.remaining, | |||
| size: uploadData.size, | |||
| uuid: uploadData.uuid | |||
| uuid: uploadData.uuid, | |||
| loaded: uploadData.loaded | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This reverts commit 32e418f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce:
s3.XhrUploadHandler
options:
, chunking: { enabled: true, concurrent: { enabled: true } }
, maxConnections: 3
, multiple: true
, resume: { enabled: true}
Chrome: Version 56.0.2924.87 (64-bit) (also on Edge)
Begin uploading a large file. Pause and continue the upload a few times
and notice that immediately or eventually (it's sporadic) the upload will
be paused but chunks will still upload in the background.
Solution: the paused state is not cleared on upload continue. initHeaders
promise success seems to be called even though the XHR is aborted. Added
file status pause check here to prevent an XHR PUT when file hsa been
paused.