merge stargate and cosmwasm-stargate into finschia #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemyblue
reviewed
Sep 15, 2022
packages/finschia/package.json
Outdated
| "description": "Utilities for LBM SDK 0.45.0-rc7", | ||
| "contributors": [ | ||
| "Simon Warta <webmaster128@users.noreply.github.com>", | ||
| "zemyblue <zemyblue@users.noreply.github.com>" |
There was a problem hiding this comment.
How about adding @loin3 's email below this line?
loin3
commented
Sep 16, 2022
If so, will it be reflected when applying lbm-sdk v0.46.0-rc8? |
loin3
commented
Sep 19, 2022
zemyblue
reviewed
Sep 20, 2022
| @@ -0,0 +1,233 @@ | |||
| # Custom Protocol Buffer Codecs | |||
There was a problem hiding this comment.
Please check this document to fit our proper explain.
zemyblue
reviewed
Sep 21, 2022
zemyblue
approved these changes
Sep 21, 2022
dudong2
approved these changes
Sep 22, 2022
Comment on lines
+107
to
+112
| // let ret: FT | NFT | null; | ||
| // if (token.typeUrl == "/lbm.collection.v1.FT") { | ||
| // ret = FT.decode(token.value); | ||
| // } else if (token.typeUrl == "/lbm.collection.v1.NFT") { | ||
| // ret = NFT.decode(token.value); | ||
| // } |
There was a problem hiding this comment.
This comment can need it later. So, it is necessary.
Thank you for checking this.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36
add finschia package that contains all the feature that lbm-sdk supports.
add additional github actions yml file for testing finschia. finschia has same tests with cosmwasm-stargate and stargate, running tests such as querying balances in same simapp fails. so I separate github actions into running finschia tests and other packages tests.