Add message encode object interface in each module #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loin3
changed the title
zemyblue
reviewed
Nov 21, 2022
| isMsgCollectionModifyEncodeObject, | ||
| isMsgCollectionRevokePermissionEncodeObject, | ||
| isMsgCreateContractEncodeObject, | ||
| isMsgDetachFromEncodeObject, |
There was a problem hiding this comment.
There is not isMsgDetachEncodeObject.
dudong2
approved these changes
Nov 29, 2022
zemyblue
approved these changes
Nov 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding
Msg*EncodeObjectto each module messages, end user does not need to import lbmjs-types to create each message's encode object.Other modules that exists in cosmjs already have message encode objects, so in this PR, token, collection, foundation module's message encode objects are added.