Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply changed event in v1.0.0-rc6 #88

Merged
merged 6 commits into from
Apr 26, 2023
Merged

apply changed event in v1.0.0-rc6 #88

merged 6 commits into from
Apr 26, 2023

Conversation

loin3
Copy link
Contributor

@loin3 loin3 commented Apr 21, 2023

Description

before this PR, token id, contract id were gotten by parsing events.
but throught rc6, kind of emitted events were changed and tests were failed.
in this PR, changed event were applied to pass tests.

Motivation and context

Finschia/finschia@v1.0.0-rc5...v1.0.0-rc7
event were changed in rc6

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I have added a relevant changelog to CHANGELOG.md.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@loin3 loin3 self-assigned this Apr 24, 2023
Copy link

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title also.

@loin3 loin3 merged commit 5602a19 into main Apr 26, 2023
@loin3 loin3 deleted the change_event branch April 26, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants