Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove UpdateParams in x/foundation #93

Merged
merged 6 commits into from
Jun 1, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented May 26, 2023

Description

related: #92

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I have added a relevant changelog to CHANGELOG.md.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue self-assigned this May 26, 2023
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue marked this pull request as ready for review May 31, 2023 13:00
jaeseung-bae
jaeseung-bae previously approved these changes Jun 1, 2023
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0Tech
0Tech previously approved these changes Jun 1, 2023
Copy link

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@loin3 loin3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems interface Params in src/modules/foundation/aminomessages.ts is not deleted

Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue dismissed stale reviews from 0Tech and jaeseung-bae via de9b216 June 1, 2023 06:58
@zemyblue zemyblue merged commit 175cb19 into main Jun 1, 2023
2 checks passed
@zemyblue zemyblue deleted the feat/apply_finschia_v2.0.0-rc1 branch June 1, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants