Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumpup cosmjs to 0.31.0 #98

Merged
merged 14 commits into from
Aug 1, 2023
Merged

Bumpup cosmjs to 0.31.0 #98

merged 14 commits into from
Aug 1, 2023

Conversation

loin3
Copy link
Contributor

@loin3 loin3 commented Jul 27, 2023

Description

In this PR, cosmjs bumped up to 0.31.0.
While we contributed to cosmjs 0.31.0 so that ibc, wasm modules are duplicated.
So wasm and ibc modules are deleted in this PR.

As ibc modules is deleted, regression tests in SigningFinschiaClient and FinschiaClient are added.
To enable ibc tests, relayer settings in scripts/with-ibc added.
Run docker compose up -d in scripts/with-ibc and run scripts/with-ibc/finschia/init.sh to enable wasm tests`

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I have added a relevant changelog to CHANGELOG.md.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@loin3 loin3 self-assigned this Jul 27, 2023
This was linked to issues Jul 27, 2023
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add IBC unittest in github action

jaeseung-bae
jaeseung-bae previously approved these changes Jul 31, 2023
@loin3 loin3 merged commit c0f71c0 into main Aug 1, 2023
2 checks passed
@loin3 loin3 deleted the bumpup_cosmjs branch August 1, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable test IBC Bump up cosmjs 0.31.0
3 participants