CI: Build, test, deploy to maven #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemyblue
reviewed
Apr 26, 2023
zemyblue
reviewed
Apr 26, 2023
loin3
reviewed
Apr 26, 2023
| @@ -37,7 +37,7 @@ dependencies { | |||
| testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:$jupiterVersion") | |||
| } | |||
|
|
|||
| java{ | |||
| java { | |||
There was a problem hiding this comment.
this change does not applied in tx/build.gradle.kts.
There was a problem hiding this comment.
I moved maven-related definition into publishing blocks in both tx/ and crypto/.
Do you mean this??
There was a problem hiding this comment.
I mean line 18 in tx/buid.gradle.kts, there is no blank between java{.
loin3
previously approved these changes
Apr 27, 2023
loin3
reviewed
Apr 27, 2023
zemyblue
previously approved these changes
Apr 27, 2023
loin3
approved these changes
Apr 27, 2023
zemyblue
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md.